Security: Unvalidated remote URL fetch from feed metadata (SSRF/internal network exposure)#579
Open
tuanaiseo wants to merge 1 commit into
Conversation
Favicon fetching uses feed-provided `websiteURL` to request documents and icons (`XMLHttpRequest` + `fetch`) without scheme/host validation. A malicious feed can force requests to internal hosts (e.g., localhost/intranet), turning the extension into a network probe and leaking request side effects. Affected files: favicon-fetcher.js Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
Member
|
Hello and sorry for the delay. Could you please clarify what kind of side effects are meant? Why is the situation here different from a user visiting an HTML page that contains a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Favicon fetching uses feed-provided
websiteURLto request documents and icons (XMLHttpRequest+fetch) without scheme/host validation. A malicious feed can force requests to internal hosts (e.g., localhost/intranet), turning the extension into a network probe and leaking request side effects.Severity:
mediumFile:
modules/favicon-fetcher.jsSolution
Validate and restrict URL schemes to
http/https, block localhost/private IP ranges unless explicitly allowed, enforce size/time limits, and consider a denylist for sensitive endpoints (metadata services, loopback).Changes
modules/favicon-fetcher.js(modified)Testing