Fix search#519
Open
Degit22 wants to merge 1 commit into
Open
Conversation
Member
|
While I'm okay with doing this in principle, this is not the right place for FTS filtering. For example, as currently implemented, all actions "for every item in the current view" would apply to items filtered out by the search filter too.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reviews asked to fix the search. Normal search in this implementation of access to the database does not work, I did what I could. It may be worth making a limit on the minimum number of characters or starting a search by a button, but on a test base of several hundred records, it worked fine.