security: harden publish workflow against Mini Shai-Hulud (pin + egress)#177
Merged
Conversation
0646933 to
bef70bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the Mini Shai-Hulud supply chain hardening campaign — closing OIDC hijack vectors in GitHub Actions publish pipelines across the brickhouse-tech org and related repos.
Changes
actions/checkoutto SHA11bd71901bbe5b1630ceea73d27597364c9af683(v4.2.2)actions/setup-nodeto SHA48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e(v6.4.0)step-security/harden-runner@a5ad31d6a139d249332a2605b85202e8c0b78450(v2.19.1) as first step with egress block allowlist--ignore-scriptstonpm cito block postinstall/preinstall script executioncontents: readto job permissions (was missing — onlyid-token: writewas set)Threat model
TeamPCP's Mini Shai-Hulud worm uses OIDC identity injection to hijack publish pipelines mid-workflow. Unpinned action refs allow SHA-swapping attacks; permissive egress allows exfiltration; missing
--ignore-scriptsallows dependency install-time code execution.Precedent
Same pattern already merged in:
Test plan
npm ci --ignore-scriptsdoes not break the publish for this package