use viewthatfits with scrollview fallback#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the onboarding container view to improve layout flexibility and code organization, and updates the build version to v1.6.9. The onboarding content is now encapsulated in its own view, and layout adapts better to different content sizes and accessibility settings. Fixes #7.
Changes:
ZStackstep switch inOnboardingContainerViewwith a newOnboardingStepContentsubview, improving code organization and encapsulation. The step transition logic and animation are moved into this new view. [1] [2]ViewThatFitsand a fallbackScrollViewto better handle large content (e.g., large Dynamic Type or long localizations), improving accessibility and layout flexibility.How to test
Author checklist
This PR: