Skip to content

use viewthatfits with scrollview fallback#8

Merged
bretth18 merged 1 commit into
mainfrom
b/7-no-complete-setup-button
May 7, 2026
Merged

use viewthatfits with scrollview fallback#8
bretth18 merged 1 commit into
mainfrom
b/7-no-complete-setup-button

Conversation

@bretth18

@bretth18 bretth18 commented May 7, 2026

Copy link
Copy Markdown
Owner

Description

This PR refactors the onboarding container view to improve layout flexibility and code organization, and updates the build version to v1.6.9. The onboarding content is now encapsulated in its own view, and layout adapts better to different content sizes and accessibility settings. Fixes #7.

Changes:

  • Replaces the direct ZStack step switch in OnboardingContainerView with a new OnboardingStepContent subview, improving code organization and encapsulation. The step transition logic and animation are moved into this new view. [1] [2]
  • Replaces fixed content area with ViewThatFits and a fallback ScrollView to better handle large content (e.g., large Dynamic Type or long localizations), improving accessibility and layout flexibility.
  • Moves the animation modifier for the onboarding progress indicator to conditionally disable animation if "Reduce Motion" is enabled.
  • Increases the onboarding container height from 520 to 600 to accommodate larger content.

How to test

  • Ensure all checks pass

Author checklist

This PR:

  • Satisfies a goal that is specific & clearly motivated
  • Adds value in isolation (whether user-facing or sustainability-related)
  • Contains a concise & easy-to-understand title + description
  • Adheres to SRP by default
  • Presents the best possible implementation to meet its goal, given constraints at hand

@bretth18 bretth18 self-assigned this May 7, 2026
@bretth18 bretth18 merged commit 020f5f0 into main May 7, 2026
2 checks passed
@bretth18 bretth18 deleted the b/7-no-complete-setup-button branch May 7, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No "Complete Setup" button

1 participant