Skip to content

Add support for the "support_tags" command when running with no hooks…#140

Open
lambdaknight wants to merge 2 commits into
breser:masterfrom
lambdaknight:master
Open

Add support for the "support_tags" command when running with no hooks…#140
lambdaknight wants to merge 2 commits into
breser:masterfrom
lambdaknight:master

Conversation

@lambdaknight

Copy link
Copy Markdown

… or in "no daemon" mode.

I added a issue (#139) about "support_tags" not working in "no daemon" mode. I made a small change that gets it working. Not sure it is the optimal way to do it, but I leave it here for your perusal.

@calvn

calvn commented Feb 22, 2017

Copy link
Copy Markdown
Contributor

Awesome! Can you add some tests for these changes?

@lambdaknight

Copy link
Copy Markdown
Author

I added a test. Sorry this took so long. I don't have much time to work on this. As a disclaimer, I want to say that I don't program in JS much, so apologies if this code is just absolutely terrible.

@breser

breser commented Aug 12, 2017

Copy link
Copy Markdown
Owner

Can you rebase this so that it picks up the fixes to the broken test suite?

@khdevel

khdevel commented Aug 24, 2017

Copy link
Copy Markdown

Could you please give some information when this fix will be merged to the master branch? Thank you @breser

@breser

breser commented Aug 24, 2017

Copy link
Copy Markdown
Owner

@khdevel Was hoping @lambdaknight would rebase this so that I could see that the tests properly pass since the test suite was broken when he did this. Hasn't happened yet so I need to find some time to do it myself.

@khdevel

khdevel commented Aug 25, 2017

Copy link
Copy Markdown

Great @breser ! I extremely need such change for my super-mega deployment process :) I am looking forward for it!

@khdevel

khdevel commented Nov 7, 2017

Copy link
Copy Markdown

...any news about the release day?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants