Adds default Quote/Unquote instances for Data.Time #57
Open
ara4711 wants to merge 1 commit into
Open
Conversation
…on ToJSON/FromJSON instances. Adds parse and format functions for UTTime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds default Quote/Unquote instances for Data.Time types that have Aeson ToJSON/FromJSON instances.
Changes:
These functions are in a sense available "for free" since they are already provided by Aeson. So, unless you
have some specific design constraints (e.g wanting to keep the number of dependencies down), I hope that you'd
find these additions worthwile.
I tried to pick "old" constraints on time and time-compat but is not overly familiar with what strategy one should take on versioning.
Happy to recieve any feedback/comments. Thanks for a really useful library!
cheers,
Andreas