Add support for mongoDb id's + make collection to lowercase work#56
Open
stuk88 wants to merge 16 commits into
Open
Add support for mongoDb id's + make collection to lowercase work#56stuk88 wants to merge 16 commits into
stuk88 wants to merge 16 commits into
Conversation
_.each is not changing the value of collections. So I replaced it with _.map
bredikhin
requested changes
Aug 17, 2017
| if (err) | ||
| return nextItem(err); | ||
|
|
||
| if(!model) |
Owner
There was a problem hiding this comment.
Space after if. It's really not a big deal, but let's stay consistent.
| else { | ||
| for (var j = 0; j < item[attr].length; j++) { | ||
| model[attr].add(that.idMap[joined][item[attr][j]-1]); | ||
| var idx = that.idMap[joined].indexOf(item[attr][j]); |
| { | ||
| "name": "barrels", | ||
| "version": "1.6.5", | ||
| "version": "1.6.7", |
Owner
There was a problem hiding this comment.
Why are you skipping a version? 🤔
Contributor
Author
There was a problem hiding this comment.
made changes twice, so upped the version twice. downgraded the version on my code now, so it will be upped only once on your side.
Assosiations functions update + Populate function update to use find function, and add a checkes for array of ids have related objects, and not fail.
switching to !isNaN
Contributor
Author
|
All Updated. Ready to pull. |
stuk88
changed the title
Contributor
Author
|
Any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.