Skip to content

ci: overhaul socket-fix workflow for verified commits and multiple issues#1371

Open
kdenhartog wants to merge 1 commit into
mainfrom
kdh/verified-socket-fix-commits
Open

ci: overhaul socket-fix workflow for verified commits and multiple issues#1371
kdenhartog wants to merge 1 commit into
mainfrom
kdh/verified-socket-fix-commits

Conversation

@kdenhartog
Copy link
Copy Markdown
Member

Summary

  • Disables socket CLI CI mode (CI: '') to prevent it from auto-creating unverified PRs
  • Adds issue_link input supporting comma-separated values for multiple GHSAs with separate issues
  • Replaces git commit/git push with the GitHub Git Data API so produced PRs have verified commits
  • Adds set -eEo pipefail / shopt -s inherit_errexit for strict error handling
  • Switches from a for loop over git diff --name-only to git status --porcelain — correctly handles new untracked files, deleted files, and filenames with spaces
  • Reads file mode from git index (git ls-files -s) instead of hardcoding 100644
  • Uses base64 -w 0 to prevent line-wrap corruption in blob content
  • Handles existing branch and PR gracefully on workflow rerun
  • Removes unnecessary author field from commit creation API call

…sues

- Disable socket CLI CI mode (CI: '') to prevent auto-PR creation
- Add issue_link input supporting comma-separated values
- Use GitHub Git Data API for verified commits
- Add set -eEo pipefail / shopt -s inherit_errexit
- Use git status --porcelain to handle new, modified, and deleted files
- Read file mode from git index instead of hardcoding 100644
- Use base64 -w 0 to avoid line-wrap corruption
- Handle existing branch and PR on workflow rerun
- Remove unnecessary author field from commit creation
@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://1371.pr.nala.bravesoftware.com/
✅ Commit preview: https://1371.pr.nala.bravesoftware.com/commit-1c25a7299affb01501fdedc974533e520a03bd08/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 8180 bytes
+ ./tokens/css/variables-ios.css: 8180 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 28568 bytes
+ ./tokens/css/variables-search.css: 28568 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 126006 bytes
+ ./tokens/css/variables.css: 126006 bytes
Variables Diff: variables-android.diff
--- ./tokens/css/variables-android.old.css	2026-04-17 13:59:16.993444584 +0000
+++ ./tokens/css/variables-android.css	2026-04-17 13:58:40.978668154 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Apr 16 2026 03:57:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Apr 17 2026 13:58:40 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-browser.diff
--- ./tokens/css/variables-browser.old.css	2026-04-17 13:59:17.297671117 +0000
+++ ./tokens/css/variables-browser.css	2026-04-17 13:58:40.961667900 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Apr 16 2026 03:57:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Apr 17 2026 13:58:40 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-ios.diff
--- ./tokens/css/variables-ios.old.css	2026-04-17 13:59:17.601860082 +0000
+++ ./tokens/css/variables-ios.css	2026-04-17 13:58:40.994668393 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Apr 16 2026 03:57:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Apr 17 2026 13:58:40 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-marketing.diff
--- ./tokens/css/variables-marketing.old.css	2026-04-17 13:59:17.925251111 +0000
+++ ./tokens/css/variables-marketing.css	2026-04-17 13:58:41.016668722 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Apr 16 2026 03:57:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Apr 17 2026 13:58:41 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-news.diff
--- ./tokens/css/variables-news.old.css	2026-04-17 13:59:18.225030317 +0000
+++ ./tokens/css/variables-news.css	2026-04-17 13:58:41.083669724 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Apr 16 2026 03:57:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Apr 17 2026 13:58:41 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-newtab.diff
--- ./tokens/css/variables-newtab.old.css	2026-04-17 13:59:18.536208734 +0000
+++ ./tokens/css/variables-newtab.css	2026-04-17 13:58:41.093669874 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Apr 16 2026 03:57:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Apr 17 2026 13:58:41 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-search.diff
--- ./tokens/css/variables-search.old.css	2026-04-17 13:59:18.909250265 +0000
+++ ./tokens/css/variables-search.css	2026-04-17 13:58:41.052669261 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Apr 16 2026 03:57:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Apr 17 2026 13:58:41 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-web3.diff
--- ./tokens/css/variables-web3.old.css	2026-04-17 13:59:19.204135048 +0000
+++ ./tokens/css/variables-web3.css	2026-04-17 13:58:41.097669934 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Apr 16 2026 03:57:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Apr 17 2026 13:58:41 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {
Variables Diff: variables.diff
--- ./tokens/css/variables.old.css	2026-04-17 13:59:19.703263009 +0000
+++ ./tokens/css/variables.css	2026-04-17 13:58:40.839666075 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Thu Apr 16 2026 03:57:20 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Apr 17 2026 13:58:40 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants