Skip to content

Bump MACOSX_DEPLOYMENT_TARGET to 10.13#26

Open
alucarded wants to merge 1 commit into
brave:mainfrom
alucarded:min_version_bump
Open

Bump MACOSX_DEPLOYMENT_TARGET to 10.13#26
alucarded wants to merge 1 commit into
brave:mainfrom
alucarded:min_version_bump

Conversation

@alucarded

@alucarded alucarded commented Jun 16, 2023

Copy link
Copy Markdown

See #25

Build started failing after switching to latest macOS Ventura 13.4 and Xcode 14.3.

Also, the supported deployment target versions start at 10.13 there:
../Sparkle.xcodeproj: warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.9, but the range of supported deployment target versions is 10.13 to 13.3.99. (in target 'Autoupdate' from project 'Sparkle')

@alucarded alucarded changed the title Bump minimum deployment target to macOS 10.11 Bump minimum deployment target to macOS 10.13 Jun 16, 2023
@jagadeshjai

Copy link
Copy Markdown

@simonhong Why it is not reviewed yet, is there any issues in this PR.

@alucarded alucarded changed the title Bump minimum deployment target to macOS 10.13 Bump MACOSX_DEPLOYMENT_TARGET to 10.13 Sep 10, 2023
@simonhong

Copy link
Copy Markdown
Member

@mherrmann Curious we also have this issue in our CI build?

@mherrmann

Copy link
Copy Markdown
Collaborator

@simonhong we use pre-built copies of Sparkle and it's possible that this issue started occurring after our latest actual build of the binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants