Simplifying Return URL#1607
Conversation
|
|
||
| is GetReturnLinkUseCase.ReturnLinkResult.DeepLink -> | ||
| returnLinkResult.deepLinkFallbackUrlScheme | ||
| returnLinkResult.deepLinkFallbackUrlScheme + "://onetouch/v1" |
There was a problem hiding this comment.
why do we need to change the deeplink url ? Shouldn't our changes be limited to applink ?
There was a problem hiding this comment.
Will this handle both
://onetouch/v1/success
and
://onetouch/v1/cancel
There was a problem hiding this comment.
Confirmed via joint testing. The following code can handle the cancel and success portion
val successUrl = "$navigationLink/success"
val cancelUrl = "$navigationLink/cancel"
while successUrl = "$returnLink/success" handles the the applink + deeplink case with the success postfix
There was a problem hiding this comment.
returnLinkResult.deepLinkFallbackUrlScheme only returns the deepLinkFallbackUrlScheme value the merchant passes to the PayPalClient constructor (i.e. "com.braintreepayments.demo.braintree" for the braintree_android demo app).
This will not included the "://onetouch/v1"
This change will make sure that both app link and deep link have '/success' in one line
|
Tech Lead Signoff: Approving changes from xo-checkout side. |
jaxdesmarais
left a comment
There was a problem hiding this comment.
Can we revert the changes to Android tests that use deeplinks and not app links? Only the tests that start will https:// should need to change. Others should be able to remain the same using scheme://onetouch/v1
|
This looks good, I have also tested all the flows: |
I second all of this! Thanks for the great description and video support! |
Summary of changes
://onetouch/v1/path segment from success and cancel URLs{navigationLink}://onetouch/v1/successand{navigationLink}://onetouch/v1/cancelto{navigationLink}/successand{navigationLink}/cancelfor AppLinksPayPalInternalClientAI Usage
Which AI Agent Was Used?
How was AI used?
Estimated AI Code Contribution
Checklist
Authors
Inner Source Process
Internal to PayPal contributors should fill out this section. All others can delete.
PR should follow these steps before codeowners review will begin:
tech lead review required, andinner sourcelabeltech lead review requiredlabel removedInner Source Checklist
Test Steps
Test App: Braintree Demo App
Prerequisites
1. PayPal Checkout (Single Payment)
2. PayPal Vault (Billing Agreement)
3. PayPal Cancellation
What to Look For
Evidence
ECS Applink Verification (Success and Cancel)
ECS.Flow.Applink.mov
VA Applink Verification (Success and Cancel)
VA.Flow.Applink.mov
Deeplink Fallback Verification (Success)
Deeplink.Fallback.Onetouch.mov
Deeplink Fallback Verification (Cancel)
Deeplink.Fallback.Cancel.mov