fix: nightly hardening - CLI config load guards#36
Open
mouse-value-add wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem
PromptLens
runassumes config YAML always parses into a top-level object. Empty files or non-object YAML (like lists) can trigger confusing downstream errors during override/parsing.approach
_load_config_data()inpromptlens/cli.pyto centralize config loading.runto use this loader before applying CLI overrides.verification
python3 -m pytest -q tests/test_cli_config_loading.py tests/test_cli_hardening.pyrisks
rollback plan
f2ff9ffto restore previous config loading behavior.