fix: nightly hardening - CLI config top-level validation#34
Open
mouse-value-add wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem
promptlens runassumes the YAML config always parses into a mapping. Empty files (None) or non-mapping top-level YAML (for example a list) fail later with less clear behavior and weaker guardrails.approach
RunConfigparsing.verification
python3 -m pytest -qtest_run_rejects_empty_config_filetest_run_rejects_non_mapping_top_level_configrisks
rollback plan
e2ab2a8to restore previous behavior.