fix: nightly hardening - config numeric bounds validation#22
Open
mouse-value-add wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PromptLens accepted invalid numeric config values (for example negative retry delay, zero timeout, or out-of-range temperature). These values can slip through config load and fail later at runtime in less obvious ways.
Approach
promptlens/models/config.py:temperatureconstrained to0.0..2.0max_tokensandtimeoutconstrained to positive valuesparallel_requestspositive,retry_attemptsnon-negativeretry_delay_secondsnon-negative,timeout_secondspositivetests/test_config_bounds_validation.pywith focused negative cases to ensure invalid values are rejected at parse time.Verification
python3 -m pytest -q tests/test_config_bounds_validation.pyRisks
Rollback Plan
c84798bto restore previous permissive behavior.