Add animated 2d example - #129
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
==========================================
+ Coverage 69.63% 72.08% +2.45%
==========================================
Files 5 5
Lines 326 326
==========================================
+ Hits 227 235 +8
+ Misses 99 91 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hi @BhoomikaC15, sorry for the delay in reviewing this. This example looks useful (and works first time!), but the changes to the tests don't seem to be related. Would you mind removing them? A couple of other suggestions:
|
64b8740 to
d25b235
Compare
for more information, see https://pre-commit.ci
|
Hi @adamltyson, I’ve completed the example updates you requested. Sorry for the extra test files, they were my mistake. I had already added similar tests in a separate PR that’s now merged, but I accidentally included them here as well. I’ve removed those test files from this PR. Also, the remaining GitHub failure looks unrelated to the example changes and seems to come from the repository’s Python 3.12 dependency chain. Since that may be a repo-wide issue, would you prefer I open a separate PR for that, or should I keep this PR scoped only to the example updates? |
|
Hi @BhoomikaC15, you seem to have deleted the test files themselves. Could you make sure the tests aren't touched at all? There should be just one change in this PR, your new example file. #144 fixed the CI, so if you merge main into this PR, everything should pass. Thanks! |
Description
What is this PR
Why is this PR needed?
This PR adds an example showing how to generate an animated 2D heatmap across slice positions. It provides a reference implementation for users who want to visualize how region values vary across the brain volume rather than viewing a single static slice.
What does this PR do?
Adds a new example script,
examples/heatmap_animated.py, which:brainglobe-heatmapmatplotlib.animationReferences
Relates to #106
How has this PR been tested?
Is this a breaking change?
No. This PR only adds a new example script.
Does this PR require an update to the documentation?
No.
Checklist: