Add additional tests for find_annotation_position_inside_polygon - #127
Open
ShivamRajSri wants to merge 1 commit into
Open
Add additional tests for find_annotation_position_inside_polygon#127ShivamRajSri wants to merge 1 commit into
ShivamRajSri wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
=======================================
Coverage 69.63% 69.63%
=======================================
Files 5 5
Lines 326 326
=======================================
Hits 227 227
Misses 99 99 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Additional unit tests for
find_annotation_position_inside_polygon.Why is this PR needed?
The function
find_annotation_position_inside_polygoncontains several edge-case behaviors described in the docstring, such as:buffer(0)MultiPolygonCurrently these behaviors were not fully tested. Adding these tests improves reliability and helps prevent regressions in future changes.
What does this PR do?
This PR adds additional unit tests in:
tests/test_unit/test_find_annotation_position_inside_polygon.py
The new tests cover:
Nonebuffer(0)These tests improve coverage of the polygon annotation helper function and validate behavior described in the function’s documentation.
References
No related issue.
Tests were added to improve coverage and validate documented edge cases.
How has this PR been tested?
The new tests were executed locally using:
pytest tests/test_unit/test_find_annotation_position_inside_polygon.py -v
All tests pass locally. Existing tests were also run to ensure that no current functionality is affected.
Pre-commit hooks were run to ensure formatting and linting compliance.
Is this a breaking change?
No.
This PR only adds tests and does not modify any existing functionality.
Does this PR require an update to the documentation?
No.
This PR only adds unit tests and does not introduce any new functionality or change existing behavior.
Checklist: