Fix SSML stripping inside tags#1103
Closed
DaTeVo wants to merge 3 commits into
Closed
Conversation
Signed-off-by: DaTeVo <voeltemata@gmail.com>
Collaborator
|
Thanks for spotting this! I'm thinking that the loop could instead be reworked a bit. I was actually surprised that it was including i == len. We don't actually need that, but we need to terminate the out string. It seems to me we should rather simplify the loop:
|
Contributor
Author
|
Thank you for the review. I will take care of it on Wednesday. |
Signed-off-by: DaTeVo <voeltemata@gmail.com>
sthibaul
reviewed
Jun 17, 2026
daxmawal
reviewed
Jun 17, 2026
Co-authored-by: Jean-François David <jeanfrancoismanutea@gmail.com>
Collaborator
|
squashed and pushed, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
module_strip_ssml()to ignore XML entities inside SSML tags.Previously:
produced:
It now produces: