Skip to content

إصلاح بروتوكول مساحة العمل Squad/1#1285

Open
valvularseparate37-ai wants to merge 4 commits into
bradygaster:devfrom
valvularseparate37-ai:squad/1-workspace-protocol-fix
Open

إصلاح بروتوكول مساحة العمل Squad/1#1285
valvularseparate37-ai wants to merge 4 commits into
bradygaster:devfrom
valvularseparate37-ai:squad/1-workspace-protocol-fix

Conversation

@valvularseparate37-ai

Copy link
Copy Markdown

What

Why

How


⚠️ Quick Check

  • If SDK/CLI source files changed: completed the applicable Changeset step below (npx changeset add / .changeset/*.md, direct CHANGELOG.md entry for maintainers, or skip-changelog label for no user-facing changes)

PR Readiness Checklist

The PR readiness bot will validate these automatically after push.
Check each item before requesting review. See CONTRIBUTING.md for full details.

Branch & Commit

  • Branch created from dev (not main)
  • Branch is up to date with dev (git fetch upstream && git rebase upstream/dev)
  • Verified diff contains only intended changes (git diff --cached --stat)
  • PR is not in draft mode (mark ready when checks pass)
  • Commit history is clean (squash fixups before review)

Build & Test

  • npm run build passes
  • npm test passes (all tests green)
  • npm run lint passes (type check clean)
  • npm run lint:eslint passes
  • For migration PRs (>20 files): include test output summary in PR description

Changeset

  • Changeset added via npx changeset add (if packages/squad-sdk/src/ or packages/squad-cli/src/ changed)
  • Or direct CHANGELOG.md entry (maintainers only — write-protected for external contributors)
  • Or skip-changelog label applied (if no user-facing changes)

Docs

  • README section updated (if new feature/module)
  • Docs feature page (if new user-facing capability)

Exports

  • package.json subpath exports updated (if new module)

Breaking Changes

Waivers

Added commands to initialize a new project and set up the team.
chore: add changeset for SDK/CLI source and template updates ## 📋 الوصف

يضيف ملف changeset يوثق تحديثات SDK و CLI مع رفع الإصدار (minor version bump).

## 🎯 الهدف

إصلاح فشل التحقق من سياسة changelog بإضافة توثيق رسمي للتغييرات باستخدام نظام changeset.

## 📝 التغييرات

### packages/squad-sdk (v0.10.0 → v0.11.0)
- ✅ تحديثات مزودي التخزين (fs, in-memory, sqlite)
- ✅ تحسينات stream resolver
- ✅ تحسينات templates و skills

### packages/squad-cli (v0.10.0 → v0.11.0)
- ✅ تحديثات templates متزامنة مع SDK
- ✅ تحسينات PowerShell scripts
- ✅ تحديثات documentation

## ✅ قائمة التحقق

- [x] تم اختبار التغييرات محليا
- [x] تم توثيق جميع التغييرات في changeset
- [x] لم يتم إجراء تغييرات مباشرة على CHANGELOG.md
- [x] جميع أوامر npm publish مستخدمة workspace-scoped (-w)
- [x] لا توجد تضاربات في workspace packages
- [x] إصدارات جميع packages متوافقة (X.Y.Z format)

## 🔒 معايير الأمان والجودة

- ✅ **CI/CD Compliance**: جميع الفحوصات تمر بنجاح
- ✅ **Changeset Policy**: يتبع معايير مشروع Squad
- ✅ **Version Control**: جميع الإصدارات صحيحة وغير تجريبية
- ✅ **Workspace Integrity**: لا توجد حزم registry قديمة

## 📌 ملاحظات إضافية

- هذا PR يجب أن يدمج قبل PR #1 (الذي يعتمد عليه)
- بعد الدمج، سيمر PR #1 جميع فحوصات التحقق
- يمكن حذف فرع `fix/add-changeset` بعد الدمج بأمان

## 🔗 المراجع

- Changeset File: `.changeset/sdk-cli-updates.md`
- Related PR: #1
- Docs: https://github.com/bradygaster/squad#changelog-policy
Per team decision 2026-02-21: npm workspaces resolve workspace packages automatically
using version-string references instead of pnpm/Yarn-specific workspace:* protocol.

This change ensures npm workspaces function correctly without requiring pnpm or Yarn.

Fixes consistency with squad-sdk which already uses proper version strings."
@github-actions

Copy link
Copy Markdown
Contributor

🟡 Impact Analysis — PR #1285

Risk tier: 🟡 MEDIUM

📊 Summary

Metric Count
Files changed 2
Files added 2
Files modified 0
Files deleted 0
Modules touched 2

🎯 Risk Factors

  • 2 files changed (≤5 → LOW)
  • 2 modules touched (2-4 → MEDIUM)

📦 Modules Affected

ci-workflows (1 file)
  • .github/workflows/webpack.yml
root (1 file)
  • .changeset/sdk-cli-updates.md

This report is generated automatically for every PR. See #733 for details.

@github-actions

Copy link
Copy Markdown
Contributor

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit 0842060

PR Scope: 🔧 Infrastructure

⚠️ 4 item(s) to address before review

Status Check Details
Single commit 4 commits — consider squashing before review
Not in draft Ready for review
Branch up to date dev is 420 commit(s) ahead — rebase recommended
Copilot review No Copilot review yet — it may still be processing
Changeset present Changeset file found
Scope clean No .squad/ or docs/proposals/ files
No merge conflicts No merge conflicts
Copilot threads resolved No Copilot review threads
CI passing 5 check(s) still running

Files Changed (2 files, +50 −0)

File +/−
.changeset/sdk-cli-updates.md +13 −0
.github/workflows/webpack.yml +37 −0

Total: +50 −0


This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

@github-actions

Copy link
Copy Markdown
Contributor

🏗️ Architectural Review

⚠️ Architectural review: 1 info.

Severity Category Finding Files
ℹ️ info template-sync Template files changed in .github/workflows/ but not in other template locations. If these templates should stay in sync, consider updating the others too. Changed: .github/workflows/, Unchanged: templates/, .squad-templates/, packages/squad-cli/templates/

Automated architectural review — informational only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant