fix(cli): add externalize/internalize to top-level squad --help (#1050)#1232
Open
primetimetank21 wants to merge 1 commit into
Open
fix(cli): add externalize/internalize to top-level squad --help (#1050)#1232primetimetank21 wants to merge 1 commit into
primetimetank21 wants to merge 1 commit into
Conversation
The top-level `squad --help` command list omitted the externalize and internalize commands, leaving them undiscoverable. Add both entries (descriptions sourced verbatim from command-help.ts) plus a regression test guarding the top-level command list. Closes bradygaster#1050 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
🛫 PR Readiness Check
PR Scope: 📦🔧 Mixed (product + infrastructure)
|
| Status | Check | Details |
|---|---|---|
| ✅ | Single commit | 1 commit — clean history |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | Changeset file found |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | No Copilot review threads |
| ✅ | CI passing | All checks passing |
Files Changed (3 files, +8 −1)
| File | +/− |
|---|---|
.changeset/help-externalize-internalize.md |
+5 −0 |
packages/squad-cli/src/cli-entry.ts |
+2 −0 |
test/human-journeys.test.ts |
+1 −1 |
Total: +8 −1
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
Contributor
🟡 Impact Analysis — PR #1232Risk tier: 🟡 MEDIUM 📊 Summary
🎯 Risk Factors
📦 Modules Affectedroot (1 file)
squad-cli (1 file)
tests (1 file)
This report is generated automatically for every PR. See #733 for details. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the CLI help output and related tests so the new externalize and internalize commands are visible in squad --help.
Changes:
- Add
externalizeandinternalizeto the top-levelsquad --helpcommand list. - Update the cross-journey test to expect these commands in help output.
- Add a changeset to publish the help-text update as a patch.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/human-journeys.test.ts | Extends the help-discoverability test to include externalize/internalize. |
| packages/squad-cli/src/cli-entry.ts | Prints externalize/internalize in the --help command list. |
| .changeset/help-externalize-internalize.md | Declares a patch release for the help output update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the
externalizeandinternalizecommands to the top-levelsquad --helpcommand listing so they are discoverable, and adds a regression test that guards the listing.Why
Closes #1050. Both commands already exist and have per-command help (
squad externalize --help,squad internalize --help), but they were missing from the top-levelsquad --helpcommand list. Users browsingsquad --helphad no way to discover them.How
packages/squad-cli/src/cli-entry.ts, placed alphabetically betweenlinkandbuildto match the surrounding ordering.packages/squad-cli/src/cli/core/command-help.ts, and the column alignment matches the existing long-command-name precedent (e.g.scrub-emails,copilot-bridge).test/human-journeys.test.tsrather than adding a new test, keeping the diff minimal..changeset/help-externalize-internalize.md, patch to@bradygaster/squad-cli)PR Readiness Checklist
Branch & Commit
dev(notmain)dev(ahead 1, behind 0 at time of push)git diff --cached --stat: 3 files, +8/-1)Build & Test
npm run buildpassesnpm run lintpasses (type check clean)test/human-journeys.test.ts, command-help tests)npm testfull suite — letting CI be the arbiter. Locally on a fresh Windows clone the full suite has pre-existing environmental failures (worker-RPC timeouts,npm pack/install integration smoke tests, storage-provider FS-contract tests) that are present on untoucheddevas well; a baseline run of cleandevfailed more than this branch, confirming this change introduces zero new failures.Changeset
.changeset/help-externalize-internalize.md, patch to@bradygaster/squad-cli)Docs
Exports
Breaking Changes
None.
Waivers
None.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com