feat: policy helper for trigger-based runtime rules#23
Merged
Conversation
Collaborator
Author
Collaborator
Author
|
Thanks for the policy-helper work — I reviewed the implementation and tests, and the runtime gating logic itself looks solid.\n\nOne blocking issue before merge: this PR currently shows a very large cross-cutting diff (35 files) well beyond the policy-helper scope in the description. It appears the branch may be based against the wrong target branch () or includes unrelated changes.\n\nCould you please either:\n1) retarget/rebase so this PR contains only the policy-helper/tool-gate changes, or\n2) split unrelated changes into separate PR(s)?\n\nOnce the diff is scoped, I can complete a final pass quickly. |
Collaborator
Author
|
Follow-up clarification: by wrong target branch I specifically mean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Policy_Helperas the runtime policy authority for trigger-based runs (chat,heartbeat,spawned_agent)Abilities_Helperfor tools/destructive/file-delete checks with structured policy-violation payloadsCloses #14
Validation
composer testcomposer lint