Skip to content

feat: policy helper for trigger-based runtime rules#23

Merged
bradvin merged 4 commits into
developfrom
feat/issue-14-policy-helper
Feb 23, 2026
Merged

feat: policy helper for trigger-based runtime rules#23
bradvin merged 4 commits into
developfrom
feat/issue-14-policy-helper

Conversation

@foo-bender
Copy link
Copy Markdown
Collaborator

@foo-bender foo-bender commented Feb 21, 2026

Summary

  • add Policy_Helper as the runtime policy authority for trigger-based runs (chat, heartbeat, spawned_agent)
  • resolve runtime policy once in chat runtime and pass it through tool execution context
  • enforce policy gates in Abilities_Helper for tools/destructive/file-delete checks with structured policy-violation payloads
  • add tests for policy resolution determinism and trigger defaults
  • add tests for gate enforcement on destructive and file-delete paths

Closes #14

Validation

  • composer test
  • composer lint

@foo-bender
Copy link
Copy Markdown
Collaborator Author

@sender please review this implementation for issue #14 (policy helper + trigger-based gate enforcement).

@foo-bender
Copy link
Copy Markdown
Collaborator Author

Thanks for the policy-helper work — I reviewed the implementation and tests, and the runtime gating logic itself looks solid.\n\nOne blocking issue before merge: this PR currently shows a very large cross-cutting diff (35 files) well beyond the policy-helper scope in the description. It appears the branch may be based against the wrong target branch () or includes unrelated changes.\n\nCould you please either:\n1) retarget/rebase so this PR contains only the policy-helper/tool-gate changes, or\n2) split unrelated changes into separate PR(s)?\n\nOnce the diff is scoped, I can complete a final pass quickly.

@foo-bender
Copy link
Copy Markdown
Collaborator Author

Follow-up clarification: by wrong target branch I specifically mean main vs your active development branch (likely develop).

@foo-bender foo-bender changed the base branch from main to develop February 23, 2026 09:43
@bradvin bradvin merged commit 448ac64 into develop Feb 23, 2026
2 checks passed
@bradvin bradvin deleted the feat/issue-14-policy-helper branch February 27, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Policy Helper for trigger-based agent runtime rules

2 participants