Skip to content

feat: extend contract checks DAG with customers task#5

Merged
br413 merged 1 commit into
mainfrom
feat/dqo-customers-dag
Jul 15, 2026
Merged

feat: extend contract checks DAG with customers task#5
br413 merged 1 commit into
mainfrom
feat/dqo-customers-dag

Conversation

@br413

@br413 br413 commented Jul 15, 2026

Copy link
Copy Markdown
Owner

Renames DAG to dqo_contract_checks and adds customers validation task. Closes #3 prep.


Note

Low Risk
Orchestration and documentation only; same CLI check path as before. Operators must adopt the new DAG id if anything referenced the old name.

Overview
Renames the scheduled Airflow DAG from dqo_orders_contract_checks to dqo_contract_checks and replaces the single orders-only task with two daily Bash tasks: orders first, then customers (run_orders_checks >> run_customers_checks).

Shared CLI flags (references, history DB, alert file, no console alerts) are factored into a CHECK_COMMAND constant; each task only adds contract and data paths. README, docs/scheduling.md, and tests/test_dags.py are updated for the new DAG id, file name dags/dqo_contract_checks.py, and the expectation of two tasks.

Reviewed by Cursor Bugbot for commit d003a5f. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d003a5f. Configure here.

),
)

run_orders_checks >> run_customers_checks

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orders failure skips customers checks

Medium Severity

run_orders_checks is wired upstream of run_customers_checks, and the CLI exits with a non-zero code when contract checks fail. Airflow then skips the customers task, so a failing orders run leaves the customers contract unvalidated for that schedule despite independent data and contracts.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d003a5f. Configure here.

@br413
br413 merged commit 90a46d3 into main Jul 15, 2026
2 checks passed
@br413
br413 deleted the feat/dqo-customers-dag branch July 15, 2026 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Prometheus metrics exporter for check runs

1 participant