feat: extend contract checks DAG with customers task#5
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d003a5f. Configure here.
| ), | ||
| ) | ||
|
|
||
| run_orders_checks >> run_customers_checks |
There was a problem hiding this comment.
Orders failure skips customers checks
Medium Severity
run_orders_checks is wired upstream of run_customers_checks, and the CLI exits with a non-zero code when contract checks fail. Airflow then skips the customers task, so a failing orders run leaves the customers contract unvalidated for that schedule despite independent data and contracts.
Reviewed by Cursor Bugbot for commit d003a5f. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Renames DAG to dqo_contract_checks and adds customers validation task. Closes #3 prep.
Note
Low Risk
Orchestration and documentation only; same CLI check path as before. Operators must adopt the new DAG id if anything referenced the old name.
Overview
Renames the scheduled Airflow DAG from
dqo_orders_contract_checkstodqo_contract_checksand replaces the single orders-only task with two daily Bash tasks: orders first, then customers (run_orders_checks >> run_customers_checks).Shared CLI flags (references, history DB, alert file, no console alerts) are factored into a
CHECK_COMMANDconstant; each task only adds contract and data paths. README,docs/scheduling.md, andtests/test_dags.pyare updated for the new DAG id, file namedags/dqo_contract_checks.py, and the expectation of two tasks.Reviewed by Cursor Bugbot for commit d003a5f. Bugbot is set up for automated code reviews on this repo. Configure here.