Logging adjustments to extracted function files#63
Open
valbucci wants to merge 42 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an error log file created when not a single function was processed successfully in
bytes,bytes-masked, andfunc-cfgmodes. This error log file would be created even if there were no function to process in the first place (e.g. due to the--min-basic-blockssetting).This PR replaces that error due to empty function lists with a warning.
Additionally, it fixes one issue where a directory name with a dot in it would result in incorrect error log file naming.
For example: The error log file for a directory called
libpng16.so.16.43.0_byteswould becomelibpng16.so.16.43.error.log, when it should have beenlibpng16.so.16.43.0_bytes.error.log. This errors is caused by the PathBuf functionwith_extension. A more robust function calledget_error_filepathhas been created to fix this issue and provide error log file paths consistently.