osmordred: add rdkit217 descriptor set (217 standard RDKit descriptors)#34
Open
guillaume-osmo wants to merge 1 commit into
Open
osmordred: add rdkit217 descriptor set (217 standard RDKit descriptors)#34guillaume-osmo wants to merge 1 commit into
guillaume-osmo wants to merge 1 commit into
Conversation
Adds RDKit217Descriptors: 217 standard RDKit physicochemical/topological
descriptors computed in C++, in the exact order of Python's
Descriptors._descList. Exposed via ExtractRDKitDescriptors,
ExtractRDKitDescriptorsBatch, ExtractRDKitDescriptorsFromMolsBatch, and
GetRDKit217DescriptorNames.
- Code/GraphMol/Descriptors/rdkit217/{RDKit217Descriptors.cpp,.h,test_rdkit217.cpp}
- Osmordred.h: declare calcEState_VSA / calcVSA_EState (defined in
OsmordredBasicPhyschemCountsRules.cpp) so rdkit217 can reuse the MOE-VSA terms.
- CMake wiring + Python wrapper bindings, all under RDK_BUILD_OSMORDRED.
Independent of the osmordredv3 PR and the smarts291 PR; branches off osmordred.
Assisted by Claude
Owner
|
We already have a way of doing this: Might be worth checking to see if it has all 217 descriptors though. Might be missing some. |
Author
|
the idea is was port all descriptors into cpp itself then have a fast generator of them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the rdkit217 descriptor set — 217 standard RDKit physicochemical/topological descriptors computed in C++, in the exact order of Python's
Descriptors._descList.Independent of the osmordredv3 PR and the smarts291 PR; branches off
osmordred.Contents
Code/GraphMol/Descriptors/rdkit217/{RDKit217Descriptors.cpp,.h,test_rdkit217.cpp}Osmordred.h: declarescalcEState_VSA/calcVSA_EState(defined inOsmordredBasicPhyschemCountsRules.cpp) so rdkit217 can reuse the MOE-VSA terms.ExtractRDKitDescriptors,ExtractRDKitDescriptorsBatch,ExtractRDKitDescriptorsFromMolsBatch,GetRDKit217DescriptorNames) underRDK_BUILD_OSMORDRED.Assisted by Claude