fix: BaseImage skeleton 표시 지연 처리#753
Open
bottlenote-app[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈 (Related Issue)
PR 타입 (Type of Change)
변경 사항 (Changes)
BaseImageskeleton 표시를 즉시 노출하지 않고 100ms 이후에도 이미지 로딩 중일 때만 표시하도록 변경isLoading과showSkeleton상태를 분리변경 이유 (Reason for Changes)
isLoading초기값이true라 캐시된 이미지도 첫 렌더에서 skeleton이 잠깐 노출되어 UX상 깜빡임이 발생할 수 있었습니다.useLayoutEffect로 paint 전 동기 체크를 수행하는 방식보다, 이미지가 많은 화면에서도 paint blocking 부담이 적은 100ms delayed skeleton 방식을 적용했습니다.스크린샷 (Screenshots)
테스트 방법 (Test Procedure)
pnpm exec eslint src/components/ui/Display/BaseImage.tsxpnpm lintpnpm exec tsc --noEmit실행 시 기존src/api/auth/auth.api.test.ts의 Response mock 타입 오류로 실패 확인셀프 체크리스트 (Self Checklist)
pnpm lint통과참고 사항 (Additional Information)
pnpm lint는 기존 warning만 출력하고 exit code 0으로 통과했습니다.tsc --noEmit실패는 이번 변경 파일이 아닌 기존 테스트 mock 타입 이슈입니다.