feat: add curation v2 tab feed#751
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈 (Related Issue)
PR 타입 (Type of Change)
변경 사항 (Changes)
code값을 API 요청 파라미터로 전달하도록 변경했습니다.시음회/큐레이션탭을 노출하고, 탭 상태를 서버 code와 동일한 search param 값으로 관리하도록 개선했습니다.WHISKY_TASTING_EVENTRECOMMENDED_WHISKYrouter.push로 히스토리를 남겨 뒤로가기/앞으로가기에서도 탭 상태가 복원되도록 처리했습니다.AutoMarqueeText컴포넌트로 marquee 애니메이션이 동작하도록 추가했습니다.시음회탭을 추가하고, 홈 전용 compact 시음회 미리보기 카드와시음회 더보기CTA 카드를 추가했습니다.변경 이유 (Reason for Changes)
code파라미터를 전달해야 합니다.스크린샷 (Screenshots)
테스트 방법 (Test Procedure)
pnpm lintpnpm exec eslint 'src/app/(primary)/curation/page.tsx' 'src/app/(primary)/curation/[id]/page.tsx'pnpm exec eslint src/components/feature/home/HomeFeaturedSection.tsx src/components/feature/home/HomeTastingEventPreview.tsx src/components/feature/home/_components/HomeTastingEventPreviewCard.tsxpnpm exec tsc --noEmit --pretty false 2>&1 | rg 'src/(components/feature/home|api/curation-v2|app/\\(primary\\)/curation|queries|style)'/curation진입 시 시음회 탭이 기본 선택되는지 확인합니다./curation?tab=RECOMMENDED_WHISKY진입 시 큐레이션 탭이 선택되는지 확인합니다.시음회탭 선택 시 compact 시음회 카드와시음회 더보기카드가 노출되는지 확인합니다.셀프 체크리스트 (Self Checklist)
pnpm lint통과참고 사항 (Additional Information)
pnpm exec tsc --noEmit은 기존src/api/auth/auth.api.test.ts의Responsemock 타입 오류로 실패합니다. 이번 변경 범위인 home/curation/queries/style 경로에서는 타입 오류가 없는 것을 별도로 확인했습니다.pnpm lint는 exit 0으로 통과하지만, 기존 파일들의 warning은 남아 있습니다.