fix: Product API에서 삭제 위스키 제외#657
Open
bottlenote-app[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
#219대응: Admin에서 삭제 처리한 위스키가 Product API에 노출되지 않도록 Product read-path에 soft-delete 필터를 보강했습니다.변경 내용
deletedAt is null기준 적용existsByAlcoholId에서도 삭제 데이터 제외ALCOHOL_NOT_FOUND로 처리includeDeleted및 Admin 상세 조회는 삭제 데이터 확인 가능하도록 유지검증
./gradlew :bottlenote-mono:compileJava :bottlenote-product-api:compileTestJava./gradlew :bottlenote-mono:test --tests app.bottlenote.alcohols.service.DefaultAlcoholFacadeTest./gradlew :bottlenote-product-api:integration_test --tests ...는 Testcontainers Docker client 초기화 실패로 실행 환경에서 실패했습니다. 실패 지점은 Spring context의 DockerClientProviderStrategy 초기화이며, 테스트 assertion 실패는 확인되지 않았습니다.관련