fix: 큐레이션 hidden input 페이지 스크롤 확장 수정#87
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 제목 (Title)
변경 사항 (Changes)
sr-only에서hidden으로 변경했습니다.sr-only에서hidden으로 변경했습니다.hidden처리하고 기존 inputaria-label접근성 경로를 유지했습니다.변경 이유 (Reason for Changes)
sr-only파일 input/label이 스크롤 컨테이너 내부의 절대 위치 요소로 계산되어document.documentElement.scrollHeight가 viewport보다 크게 늘어났습니다.<main>내부에 있어야 하지만,html영역에도 별도 하단 스크롤이 생기는 문제가 발생했습니다.sr-only보다 레이아웃에 전혀 참여하지 않는hidden이 적합합니다.테스트 방법 (Test Procedure)
https://admin.development.bottle-note.com/dashboard/curations/pairings/newdocument.documentElement.scrollHeight가577 → 2001로 증가하는 것 확인.sr-only,getBoundingClientRect().top ≈ 1531.5document.documentElement.scrollHeight = 577,document.body.scrollHeight = 577유지main.scrollHeight만 실제 폼 높이에 맞게 증가className: hidden, rect 0x0 확인pnpm test:run -- src/pages/curation/whisky-tasting-event/__tests__/CurationWhiskyTastingEventCreate.test.tsx src/pages/curation/whisky-curation/__tests__pnpm build:devpnpm lintgit diff --check참고 사항 (Additional Information)
html/documentElementscrollHeight가 커지는 케이스로 확인했습니다.aria-label로 유지됩니다.