[refactor] 큐레이션 v2 폼 구조 정리#84
Merged
Merged
Conversation
f91dbd1 to
69e5778
Compare
69e5778 to
8bc7cc1
Compare
8bc7cc1 to
e3d9d5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 제목 (Title)
[refactor] 큐레이션 v2 폼 구조 정리
변경 사항 (Changes)
WhiskyTastingEventForm,WhiskyCurationForm으로 정리하고, create gate가 spec 조회/로딩/차단 상태를 맡도록 구조를 나눴습니다.노출 시작일/노출 종료일로 표시하고 필수 표시 및 range validation 테스트를 보강했습니다.origin/main기준으로 브랜치를 재정렬해 충돌을 해소했습니다.변경 이유 (Reason for Changes)
기존 큐레이션 작성 화면은 spec별 page component와 form component 책임이 섞여 있어 생성/수정 화면 차이를 추적하기 어려웠습니다. spec code별 page가 presentation을 조립하고 공통 form이 저장 흐름을 담당하도록 나눠, 시음회/추천 위스키/위스키 페어링의 진입점과 공통 레이어를 명확히 했습니다.
테스트 방법 (Test Procedure)
pnpm test:run src/services/__tests__/curation.service.test.ts src/hooks/__tests__/useCurations.test.ts src/pages/curation/__tests__/CurationDetail.test.tsx src/pages/curation/whisky-curation/__tests__/WhiskyCurationPages.test.tsx src/pages/curation/whisky-tasting-event/__tests__/CurationWhiskyTastingEventCreate.test.tsx src/pages/curation/__tests__/CurationEntry.test.tsxpnpm exec eslint <큐레이션 변경 TS/TSX 파일>pnpm build참고 사항 (Additional Information)
git.environment-variablessubmodule 변경이 남아 있으나, 이번 PR 커밋에는 포함하지 않았습니다.