Service, interceptor, models and testing component#2
Open
borisjotic wants to merge 4 commits into
Open
Conversation
borisjotic
changed the title
ervinOrion
reviewed
Nov 8, 2022
| const requestIgnored = | ||
| this.requestForIgnore.filter((ignoreReq) => | ||
| ignoreReq.toLowerCase().endsWith(url) | ||
| ).length === 0; |
Owner
Author
There was a problem hiding this comment.
With that change, we'll get a bit different if statement bellow and with it everything...
const requestNotIgnored = !!(...).length;
if(requestNotIgnoired) {
return output;
}
return null;Should I proceed?
There was a problem hiding this comment.
for your logic you need to use !, but in general use conversion to boolean, not comparation with 0
Owner
Author
There was a problem hiding this comment.
yy, the !! consfused me, change is comming ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable files:
src/app/core/interceptors/http-loader.interceptor.ts-> will intecept request(s) and show/hide loader (main or dedicated)src/app/core/services/loader-state.service.ts-> the service for loader, all logic is placed here with aditional utility methods (for dedicated/no loader scenario)src/app/shared/enums/header-name.enum.ts-> enum for headers used by interceptor/servicesrc/app/shared/models/loader-header.model.ts-> type representing header used by interceptor/service to determin type of loader to showUsage examples could be found in
src/app/loader-test/loader-test.component.ts:171-237