Do not print add_query_arg directly#3
Open
rips-hb wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Pär,
you may have seen the discussion at https://wordpress.org/support/topic/this-plugin-has-a-worryingly-high-coderisk-rips-score/ already. The problem occurs because the return value of add_query_arg is printed directly and it contains user input, so it is reported as a XSS vulnerability. Since there is a NONCE check the real security risk should be pretty low but I think it is still a good idea to resolve this. As a quick fix I just encode the value with Base64. A cleaner patch would be to return JSON (and very importantly, the json content type) and parse that instead.
Best regards,
Hendrik