Add automatic Android NDK provisioning#147
Merged
Merged
Conversation
Contributor
Author
|
@bonede This is the final PR for the Android NDK auto-provisioning change. It keeps existing local NDK setups working and adds a Gradle-managed fallback for fresh checkouts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bonede This PR makes Android native builds bootstrap the Android NDK automatically when no local NDK is configured.
What changed
downloadAndroidNdkGradle task that downloads the configured Android NDK version intobuild/android-ndk.buildNativedepend on that task whentreeSitterTargetsincludes Android.ANDROID_NDK_HOME,ANDROID_NDK_ROOT,ANDROID_HOME, andANDROID_SDK_ROOTsetups.Why
Android native builds currently fail on machines without a preconfigured NDK. This keeps installed NDKs working while allowing a fresh checkout to provision the required toolchain through Gradle.
Validation
./gradlew tasks --all --dry-run./gradlew :tree-sitter:buildNative --dry-run./gradlew :tree-sitter:build -PtreeSitterTargets=x86_64-macos./gradlew :buildSrc:test