Skip to content

[#114.1] Add iwyu enforcement to glfw_adapters and demo_app #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasnemer merged 1 commit into from
Nov 11, 2025
Merged

[#114.1] Add iwyu enforcement to glfw_adapters and demo_app #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions examples/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,11 @@ target_include_directories(glfw_adapters PUBLIC

target_compile_features(glfw_adapters PUBLIC cxx_std_20)

# Enable iwyu for glfw_adapters
set_target_properties(glfw_adapters PROPERTIES
CXX_INCLUDE_WHAT_YOU_USE "${IWYU_PATH};-Xiwyu;--error;-Xiwyu;--verbose=3"
)

# === Demo App Example ===

add_executable(prong_demo_app
Expand All @@ -100,6 +105,11 @@ target_compile_features(prong_demo_app PRIVATE cxx_std_20)
# Suppress unused function warnings for STB (header-only library with many utilities)
target_compile_options(prong_demo_app PRIVATE -Wno-unused-function)

# Enable iwyu for prong_demo_app
set_target_properties(prong_demo_app PROPERTIES
CXX_INCLUDE_WHAT_YOU_USE "${IWYU_PATH};-Xiwyu;--error;-Xiwyu;--verbose=3"
)

# Make example depend on formatting target
add_dependencies(prong_demo_app format-example-sources)

Expand Down
2 changes: 1 addition & 1 deletion examples/demo_app/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@
#include "scenes/demo_scene.h"
#include <GLFW/glfw3.h>

#include <cmath>
#include <filesystem>
#include <iostream>
#include <memory>
#include <string>

#ifdef __linux__
#include <sys/types.h>
Expand Down
6 changes: 0 additions & 6 deletions include/bombfork/prong/components/viewport.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,12 +169,6 @@ class Viewport : public Component {
PanChangedCallback panCallback;
SelectionCallback selectionCallback;

// Scrollbar state
bool horizontalScrollbarHover = false;
bool verticalScrollbarHover = false;
bool horizontalScrollbarDrag = false;
bool verticalScrollbarDrag = false;

public:
explicit Viewport() : Component(nullptr, "Viewport") {
// Initialize default theme
Expand Down