fix(video-edit): skip slowmo when factor is null#392
Conversation
LLM plans sometimes set factor:null; float(None) crashed plan parsing. Skip null factors like non-positive ones on both ffmpeg and bpy paths.
|
Warning Review limit reached
Next review available in: 48 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Keep only the null/non-positive slowmo factor skip.
bojieli
left a comment
There was a problem hiding this comment.
The final commit introduces two unrelated regressions. It clamps atempo to at most 1.0, so factor=0.5 no longer speeds audio to match the video, and it calls makedirs with an empty string for a bare output filename, raising FileNotFoundError before ffmpeg runs. Please revert those two drive-by changes and keep only the null-factor handling.
A slowmo effect with factor null raised TypeError in float(None).
Skip slowmo when factor is null, like non-positive factors.