Skip to content

fix(video-edit): skip slowmo when factor is null#392

Open
santhreal wants to merge 3 commits into
bojieli:mainfrom
santhreal:upstream/video-slowmo-null-factor
Open

fix(video-edit): skip slowmo when factor is null#392
santhreal wants to merge 3 commits into
bojieli:mainfrom
santhreal:upstream/video-slowmo-null-factor

Conversation

@santhreal

Copy link
Copy Markdown
Contributor

A slowmo effect with factor null raised TypeError in float(None).

Skip slowmo when factor is null, like non-positive factors.

LLM plans sometimes set factor:null; float(None) crashed plan parsing.
Skip null factors like non-positive ones on both ffmpeg and bpy paths.
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@santhreal, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 48 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 78e3d649-ddd8-4ddd-9e36-73409a9b23d7

📥 Commits

Reviewing files that changed from the base of the PR and between 7fb5692 and 9a3b9d7.

📒 Files selected for processing (3)
  • chapter5/video-edit/blender_editor.py
  • chapter5/video-edit/test_slowmo_null_factor.py
  • chapter5/video-edit/video_editor.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@bojieli bojieli left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The final commit introduces two unrelated regressions. It clamps atempo to at most 1.0, so factor=0.5 no longer speeds audio to match the video, and it calls makedirs with an empty string for a bare output filename, raising FileNotFoundError before ffmpeg runs. Please revert those two drive-by changes and keep only the null-factor handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants