Skip to content

Fixed sonar Issues - #2

Merged
bob-reis merged 3 commits into
mainfrom
fix/sonar-issues
Sep 2, 2025
Merged

Fixed sonar Issues#2
bob-reis merged 3 commits into
mainfrom
fix/sonar-issues

Conversation

@bob-reis

@bob-reis bob-reis commented Sep 2, 2025

Copy link
Copy Markdown
Owner

Summary

  • EmailWordlistGenerator.tsx: Made tooltip accessible (role="button", tabIndex, ARIA, keyboard + touch support, role="tooltip" with useId). Replaced risky field counting with a safe predicate (no Object.toString) and used optional
    chaining for generated totals. Fixed ambiguous spacing by wrapping label text in spans (all affected labels and “Email providers”).
  • EthicsNotice.tsx: Fixed ambiguous spacing in the main header by wrapping the heading text in a span next to the badge span.
  • about/page.tsx: Added explicit spaces around inline strong elements using {' '} in paragraphs, lists, and headings; adjusted several list items to include space after labels; minor spacing cleanups to avoid ambiguity.
  • emailWordlist.ts: Simplified regex from /[^0-9]+/ to /\D+/ for concise character class usage without changing behavior.

Changes

  • Feature
  • Fix
  • Refactor/Chore

High‑level bullet points of what changed.

Screenshots (UI)

image

Testing

  • Added/updated unit tests
  • Manually tested locally (npm run dev)
  • Verified build (npm run build)

Checklist

  • Follows Conventional Commits
  • Updates docs if behavior/UX changed
  • No sensitive data added to repo/logs

Notes

Additional context, migration steps, or breaking changes.

@vercel

vercel Bot commented Sep 2, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
safe-spray Ready Ready Preview Comment Sep 2, 2025 4:51pm

@sonarqubecloud

sonarqubecloud Bot commented Sep 2, 2025

Copy link
Copy Markdown

@bob-reis
bob-reis merged commit 68753a8 into main Sep 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant