Skip to content

Add global --system-certs flag and apply it to all HTTPS requests#8

Draft
Copilot wants to merge 2 commits into
mainfrom
copilot/add-flag-system-certs
Draft

Add global --system-certs flag and apply it to all HTTPS requests#8
Copilot wants to merge 2 commits into
mainfrom
copilot/add-flag-system-certs

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 20, 2026

This change introduces a global --system-certs CLI flag so users can force HTTPS calls to use the OS certificate store. It wires this behavior through shared settings and applies it consistently across GitHub API resolution and archive download paths.

  • CLI surface

    • Adds a new global option:
      • --system-certs
    • Captured in the Typer callback and stored in runtime settings.
  • TLS verification behavior

    • Extends Settings with:
      • use_system_certs: bool
      • tls_verify property (returns system CA file/path when enabled; defaults to standard verification otherwise).
    • Uses settings.tls_verify in all outbound requests.get(...) call sites:
      • latest release lookup
      • commit SHA lookup
      • release zip download
  • Test coverage updates

    • Adds focused assertions for:
      • flag-driven setting mutation (--system-certs)
      • verify= propagation in GitHub/download request calls
      • system-cert path usage when enabled
    • Updates shared test fixtures to reset settings.use_system_certs and avoid state bleed between tests.
  • Docs

    • Updates command docs and README usage examples to include --system-certs.
skillup --system-certs add myorg/skills

Copilot AI linked an issue May 20, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Add flag --system-certs to command Add global --system-certs flag and apply it to all HTTPS requests May 20, 2026
Copilot finished work on behalf of aersam May 20, 2026 07:09
Copilot AI requested a review from aersam May 20, 2026 07:09
Copy link
Copy Markdown
Contributor

@aersam aersam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work for windows cert store? Would not using truststore be better?

@copilot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add a flag --system-certs

2 participants