fix(docs): serve site from temporal-operator.bmorton.dev custom domain#137
Merged
Conversation
The docs moved from bmorton.github.io/temporal-operator to the custom domain temporal-operator.bmorton.dev, but the site failed to render: every asset, canonical, and og:url still used the /temporal-operator/ project-pages base path, so CSS/JS 404'd at the domain root. - hugo.toml: set baseURL to https://temporal-operator.bmorton.dev/ - docs.yml: drop the --baseURL override that forced the github.io subpath; build with the config baseURL instead - docs/static/CNAME: publish the custom domain to the site root so it persists across Actions deploys - resource-preview.md: fix the hardcoded /temporal-operator/preview/ button link to /preview/ Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Brian Morton <brian@mmmhm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The docs site moved from
bmorton.github.io/temporal-operatorto the custom domain https://temporal-operator.bmorton.dev, but it wasn't rendering: the page loaded unstyled because every asset,canonical, andog:urlstill used the/temporal-operator/project-pages base path, so the CSS/JS 404'd at the domain root.Root cause
The
build-deployjob overrode Hugo'sbaseURLwith--baseURL "${BASE_URL}/", whereBASE_URLcame fromactions/configure-pagesand still resolved to the oldbmorton.github.io/temporal-operatorsubpath.Changes
docs/hugo.toml—baseURL→https://temporal-operator.bmorton.dev/..github/workflows/docs.yml— drop the--baseURLoverride so the deploy builds with the configbaseURL(matching the existing preview-build job).docs/static/CNAME(new) — publishestemporal-operator.bmorton.devto the site root so the custom domain persists across Actions deploys.docs/content/tools/resource-preview.md— fix the hardcoded/temporal-operator/preview/button link to/preview/.Verification
Built locally with Hugo 0.140.2 (extended), matching CI:
/book.min….css,/favicon.png,/svg/menu.svgcanonical/og:url→https://temporal-operator.bmorton.dev/CNAMEpresent at site root; preview button →/preview/temporal-operator/strings are all legitimategithub.com/bmorton/temporal-operatorrepo links)Note
After merge, confirm the custom domain is set under Settings → Pages (the
CNAMEfile will set/keep it) and re-enable Enforce HTTPS if it was cleared.