Added method to use to existing libuv instance#6
Open
alshdavid wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all, this PR adds a method to construct a
Loopfrom an existing pointer address.My use case is reusing the Libuv bindings you have with an existing libuv instance - specifically, I am writing a Nodejs native addon and want to reuse the bindings offered by this package.
Used here from my fork: https://github.com/napi-rs/napi-rs/pull/2154/files#diff-1e236034b744d0ce6068c6b239c36a821d5550789289a8715c70c61c7ff9bbadR56
Testing this locally with a Nodejs add on works as expected