Skip to content

bluez.Manager: Only handle Battery1 as interfaces#3234

Open
infirit wants to merge 1 commit into
blueman-project:mainfrom
infirit:batteryremoved
Open

bluez.Manager: Only handle Battery1 as interfaces#3234
infirit wants to merge 1 commit into
blueman-project:mainfrom
infirit:batteryremoved

Conversation

@infirit
Copy link
Copy Markdown
Contributor

@infirit infirit commented May 9, 2026

Batteries are only added on removed as interfaces on an existing dbus object. Fixes #3233

@cschramm
Copy link
Copy Markdown
Member

I think this breaks the discovery of pre-existing batteries (via populate_devices), doesn't it?

It could be enough to simply work with dbus_object instead of device_proxy

We do need to send a battery-created signal when blueman is dealing with
existing batteries. But in my testing we always see an interface-removed
signal from BlueZ. Fixes blueman-project#3233
@sonarqubecloud
Copy link
Copy Markdown

@infirit
Copy link
Copy Markdown
Contributor Author

infirit commented May 27, 2026

I think this breaks the discovery of pre-existing batteries (via populate_devices), doesn't it?

Good catch, I forgot about that we need to handle those. From my testing though I only see the interface-removed on the bus so there is no reason for blueman to do anything _on_object_removed. Updated the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion Error in _on_object_removed when system enters low-power/lid-close state

2 participants