Optional first / last name fields on sign up form - #8
Conversation
|
Warning Review limit reached
Next review available in: 53 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe registration template now renders optional ChangesRegistration Name Fields
Estimated code review effort: 2 (Simple) | ~10 minutes Poem Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@Will-Howard or @marn-in-prod can I get eyes / explicit approval please? Merge bypassing is not enabled on this repo and I don't have permissions to change that. |
|
@joshestein sorry I didn't see the earlier review request, I'll review this today |
Will-Howard
left a comment
There was a problem hiding this comment.
Nothing blocking, just some nits. Feel free to accept or reject my "(optional)" suggestion
marn-in-prod
left a comment
There was a problem hiding this comment.
LGTM. I'm generally fine with leaving autofocus on (Will's comment) but it's not a big deal either way
Co-authored-by: Will Howard <w.howard256+github@gmail.com>
Co-authored-by: Will Howard <w.howard256+github@gmail.com>
Co-authored-by: Will Howard <w.howard256+github@gmail.com>
Updates
register.ftlto take optional first / last name (side-by-side, stacking on mobile, above email) fields. Fills a gap: email/password sign-ups left the account name empty until the /account welcome modal prompted later.I also needed to update the
input.ftlfile - without the modification, the invalidation div always renders, which leads to 8px of excess margin before the first/last name inputs and the other input fields. With the change the div will only render when there is an error message present, so the excess margin disappears.Keycloak's built-in full-name mapper joins
firstName+lastNameinto the OIDC name claim, which the website already reads on first login to backfilluserTable.name. No consumer code changes. /account stays the source of truth (single-name, not written back to Keycloak).Inert until the realm declares the attributes; if the theme ships first, Keycloak silently drops submitted names.
firstName/lastNameto User Profile JSON (no required key), and confirm the profile Full Name mapper has "Add to ID token" ON.Notes