feat: updated dhcp client arch#99
Merged
leshow merged 2 commits intoMay 9, 2026
Merged
Conversation
Collaborator
|
Yeah, I went back and forth on the enum, but I think in the end you're right about the ergonomics. Since the enum is not closed and has the unknown variant, each new addition is a breaking change to the API. It was nice to have the exhaustive matching in some cases but I believe the http library uses const as well so I think it's the right call. There are many of these enums in the repo though, so I probably won't cut a new release until they are all consistent in their representation. |
Collaborator
|
Thanks for the contribution! |
|
On Sat, May 09, 2026 at 01:09:30PM -0700, Evan Cameron wrote:
Thanks for the contribution!
+1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since both of the above are breaking changes, while doing the former I refactored the Architecture enum as a newtype variant with associated consts. IMO this provides better ergonomics than a regular enum with an
Unknownvariant and manual conversions, though I don't mind reverting to an enum if this isn't welcome.Closes #98.