Skip to content

Switch numbered enum types to repr(transparent)#105

Merged
leshow merged 3 commits into
masterfrom
use_pub_const
May 25, 2026
Merged

Switch numbered enum types to repr(transparent)#105
leshow merged 3 commits into
masterfrom
use_pub_const

Conversation

@leshow

@leshow leshow commented May 25, 2026

Copy link
Copy Markdown
Collaborator

closes #100

similar to the other PR but includes OROCode + RelayCode + v6::OptionCode. I see no reason not to include these in the change set.

@coveralls

coveralls commented May 25, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 26378880892

Coverage increased (+10.7%) to 62.937%

Details

  • Coverage increased (+10.7%) from the base build.
  • Patch coverage: 24 uncovered changes across 7 files (26 of 50 lines covered, 52.0%).
  • 4 coverage regressions across 3 files.

Uncovered Changes

File Changed Covered %
src/v6/oro_codes.rs 9 0 0.0%
src/v4/options.rs 11 4 36.36%
src/v4/bulk_query.rs 4 2 50.0%
src/v6/htype.rs 2 0 0.0%
src/v6/options.rs 4 2 50.0%
src/v4/relay.rs 10 9 90.0%
src/v6/option_codes.rs 4 3 75.0%

Coverage Regressions

4 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
src/v6/oro_codes.rs 2 0.0%
src/v4/options.rs 1 64.25%
src/v6/options.rs 1 60.9%

Coverage Stats

Coverage Status
Relevant Lines: 3003
Covered Lines: 1890
Line Coverage: 62.94%
Coverage Strength: 14.23 hits per line

💛 - Coveralls

@leshow leshow merged commit 8db438c into master May 25, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

repr(transparent) + const on numeric enums

2 participants