Resolve JuLC library sources by fully qualified class name#34
Merged
Conversation
Add a LibrarySource model and migrate library discovery/resolution to key sources by FQCN instead of simple class name. This fixes collisions between libraries with the same simple name in different packages while preserving explicit import, same-package, wildcard import, and fully-qualified static reference resolution. Also validate bundled @onchainlibrary sources so the declared package and top-level type match the resource path, and extend tests across compiler, annotation processor, testkit, CLI, playground, and Gradle plugin flows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the remaining library source resolution limitation where
OnchainLibrarclasses were indexed by simple class name. That caused collisions when different packages contained libraries with the same simple name.Changes: