feat(web): read real wallet bindings on the dashboard - #103
Open
kaylachi wants to merge 1 commit into
Open
Conversation
The wallets page only ever read the indexer/database, so a wallet whose handle was claimed on-chain showed nothing until the indexer caught up. Add a server-side read-only registry lookup (Soroban RPC simulation, no signing) and fall back to it when the database is empty, so an on-chain binding surfaces immediately. When the Identity Registry isn't deployed on the active network the page shows an honest empty state instead of a misleading 'no wallets linked' message. Closes blockchain-maxis#51
|
@kaylachi is attempting to deploy a commit to the blockchainmaxis-8449's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@kaylachi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
✅ Deploy Preview for stellar-signet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dashboard Wallets page only ever read the indexer/database, so a wallet whose handle was claimed on-chain showed nothing until the indexer caught up (and showed a misleading empty state on networks where the registry isn't even deployed).
This wires the page to the on-chain Identity Registry:
apps/web/lib/server/registry-read.ts— server-side, read-onlylookupHandleOnchain(wallet)that simulates the registry'slookupcall over Soroban RPC (no signing, no submission), plusisRegistryConfigured(). Both fail closed: unconfigured registry, unbound wallet, or unreachable RPC all returnnull/false.wallets/page.tsx— when the database is empty, falls back to the on-chain read so a binding surfaces immediately. The empty state now distinguishes 'registry not deployed on this network' from 'no wallets linked yet'.Testing
pnpm --filter @signet/web typecheck✅pnpm --filter @signet/web test✅ (54/54, incl. 3 new registry-read tests covering the config gate + fail-closed unconfigured path)pnpm --filter @signet/web lint✅Closes #51