Clarify agent harness defaults in create flow#2601
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd36b13d7c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ebcb62f66
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86f4e13e27
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e0a7edcff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97f2885b59
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 416de2bfd6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90cf41d705
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
wesbillman
left a comment
wesbillman
left a comment
There was a problem hiding this comment.
Reviewed the create/edit/defaults runtime, provider/model, credential, and submit paths at e1b8bbf. The progressive defaults flow preserves explicit harness choices, resynchronizes inherited harness changes, keeps missing-credential gates fail-closed while async satisfaction sources load, and correctly treats baked/runtime-file credentials and explicit-empty shadowing. Custom-command editing and advanced-only requirements remain reachable without automatic disclosure. CI is green, including Desktop Core, all smoke shards, and Desktop E2E integration. No blocking findings.
Withdrawing pending a deeper subsystem-by-subsystem review due to the size and statefulness of this change.
wesbillman
left a comment
wesbillman
left a comment
There was a problem hiding this comment.
Second-pass review at e1b8bbff482c1d8a2efd03d3df28b9969cbd1e48, after dismissing my initial fast approval. I re-reviewed the full 33-file diff against main by behavior rather than by file count.
Verified:
- Create state machine: initial/default runtime seeding, defaults↔custom transitions, explicit-vs-inherited harness pinning, live global-default updates, no-runtime/unavailable-runtime handling, and runtime/model/provider payload serialization.
- Readiness: provider/model normalization and required credentials agree with submit gates; baked/global/runtime-file layers follow backend precedence; async credential queries fail closed; explicit-empty shadowing is preserved.
- Global defaults/onboarding: progressive reveal, provider/model healing policy, visible fallback-runtime persistence on the next edit, file-satisfied credentials, dirty/save race protection, and runtime changes resetting dependent values.
- Instance edit: catalog arrival, inherit↔pin/custom-command transitions, prospective runtime selection, provider capability tri-state, credential gating, and update payload omission/clear/set behavior. The custom command moved out of Advanced with the same validity predicate, and advanced-only missing credentials now have a visible badge.
- Removed submit guidance: the remaining disabled paths are represented by visible fields/defaults state/setup warnings/Advanced Required badges; Enter and button submission share the same gate.
- Scoped AGENTS.md guidance was updated. Layout-only card/header changes are isolated.
I also read every automated review thread and confirmed each reported issue is addressed in the final head. Independent focused second passes found no reproducible defect. One non-blocking consistency nit remains: whitespace-only credentials are trimmed by Global Defaults validation but treated as present in Create/Edit; empty-string shadowing is correct.
CI is green at this exact head (Desktop Core/build, all smoke shards, both Desktop E2E integration shards, aggregate Desktop E2E, Semgrep, zizmor, DCO). Per review policy I did not run local tests.
…r-only * origin/main: (28 commits) Clarify agent harness defaults in create flow (#2601) chore(mobile): relax release check (#2636) fix: expose community icon control on open relays (#2640) chore(release): release Buzz Desktop version 0.4.24 (#2627) feat: remember per-community navigation location (#2629) fix(desktop): suppress Windows console flashes and reject WSL bash alias (#2587) fix(desktop): fix Windows PATH clobber and .cmd shim EINVAL (#2563) Update SECURITY.md chore(mobile): lighter-weight release process (#2144) Gate default relay auto-connect behind release flag (#2589) fix(desktop): fast-track relay restart reconnects (#2579) fix(sharing): preserve agent/team snapshot tEXt chunks through media sanitization (#2438) fix(acp): restrict DM turns to owner and verified siblings (#2591) test(desktop): live relay kill/restart reconnect gate (#2583) fix(relay): send 1012 restart close to all clients on graceful drain (#2575) fix(desktop): retry failed initial relay dials (#2564) Refine channel lifecycle settings (#2427) Fix avatar upload lifecycle edge cases (#2277) fix(observer): eager archive hydration on panel open + 200-frame pages (#2574) fix(cli): install rustls crypto provider to unbreak WSS publishes in release builds (#2590) ... Co-authored-by: npub102wg7q285p64ch2fjvstmf2ntn2sz3c4u5hmwatalc76mhsuauysftjtfj <7a9c8f0147a0755c5d499320bda5535cd5014715e52fb7757dfe3dadde1cef09@buzz.block.builderlab.xyz> Signed-off-by: npub102wg7q285p64ch2fjvstmf2ntn2sz3c4u5hmwatalc76mhsuauysftjtfj <7a9c8f0147a0755c5d499320bda5535cd5014715e52fb7757dfe3dadde1cef09@buzz.block.builderlab.xyz> # Conflicts: # desktop/src-tauri/build.rs # desktop/src/features/agents/ui/AgentDefinitionDialog.tsx # desktop/src/testing/e2eBridge.ts # desktop/tests/helpers/bridge.ts
2 participants
Summary
Test plan