fix(desktop): preserve GIF graphic control scope#2432
Open
atishpatel wants to merge 1 commit into
Open
Conversation
Co-authored-by: Codex <noreply@openai.com>
atishpatel
marked this pull request as ready for review
July 23, 2026 00:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The GIF sanitizer removes Plain Text Extensions but previously retained their preceding Graphic Control Extensions, allowing delay, disposal, or transparency state to leak onto the next image frame.
What
Risk Assessment
Low — isolated to GIF metadata sanitization; clean GIFs and graphic-control extensions attached to image frames remain byte-identical.
Verification
just devagainst the local relaycatjam.gifreproduces the relay 422 metadata rejectioncatjam.gifand confirmed the sanitized GIF uploads successfully asimage/gif80f4533bd59e065dc2ad3e51dcbfa44c454dd9a61c17f651b48f9c500f7dd793)just desktop-tauri-testjust desktop-tauri-clippyjust desktop-checkReferences
Generated with Codex