fix(relay): return NIP-01 OK for rejected EVENTs#2364
Open
thesimplekid wants to merge 1 commit into
Open
Conversation
The shared admission limits added in block#1917 responded to rejected EVENT frames with NOTICE. NIP-01 requires relays to answer every EVENT with an event-correlated OK, using accepted=false when the event is rejected. NOTICE does not provide the event correlation publishing clients need, causing them to wait until timeout instead of receiving the rejection. Return OK with the event ID and accepted=false for admission rejections and handler-capacity failures. Preserve CLOSED for rejected REQs, as required by NIP-01, and NOTICE for messages without a correlation ID. PR block#2074 established correlated CLOSED responses for rejected REQ messages and is the subscription-side precedent for this correction. Refs: block#1917, block#2074 Signed-off-by: tsk <tsk@thesimplekid.com>
thesimplekid
force-pushed
the
fix_rejected_events
branch
from
July 22, 2026 11:30
885aa65 to
585de87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared admission limits added in #1917 responded to rejected EVENT frames with NOTICE. NIP-01 requires relays to answer every EVENT with an event-correlated OK, using accepted=false when the event is rejected. NOTICE does not provide the event correlation publishing clients need, causing them to wait until timeout instead of receiving the rejection.
Return OK with the event ID and accepted=false for admission rejections and handler-capacity failures. Preserve CLOSED for rejected REQs, as required by NIP-01, and NOTICE for messages without a correlation ID.
PR #2074 established correlated CLOSED responses for rejected REQ messages and is the subscription-side precedent for this correction.
Refs: #1917, #2074