fix(git): diagnose unsupported Nostr credential helpers#2345
Open
yashhsm wants to merge 1 commit into
Open
Conversation
Buzz-managed relay Git operations require the credential authtype protocol introduced in Git 2.46. Mark those operations explicitly so git-credential-nostr reports the real requirement instead of silently falling through to a misleading username prompt. Constraint: Global helper configurations must still decline safely for unrelated remotes Rejected: Treat any configured Nostr key as Buzz-scoped | would break globally configured helpers on non-Buzz remotes Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep BUZZ_NOSTR_GIT_AUTH_REQUIRED scoped to Buzz-managed relay Git commands Tested: just ci; cargo test -p git-credential-nostr Not-tested: End-to-end relay merge under an actual Git 2.43 binary Signed-off-by: Yash Agarwal <yashhsm@gmail.com>
yashhsm
force-pushed
the
agent/diagnose-old-git-nostr-auth
branch
from
July 22, 2026 07:58
9df1c16 to
a8b1f6b
Compare
yashhsm
marked this pull request as ready for review
July 22, 2026 07:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the old-Git diagnostic portion of #2316.
git-credential-nostrwith an actionable Git 2.46+ message when credentialauthtypeis unavailableWhy
Git before 2.46 cannot use credential-helper
authtype, which Buzz's NIP-98/Nostr authorization requires. The helper previously returned empty output, so in-app merge fell through tocould not read Usernameand hid the actual compatibility problem.The explicit
BUZZ_NOSTR_GIT_AUTH_REQUIREDmarker is scoped to Buzz-managed relay commands. This avoids turning a globalgit-credential-nostrinstallation into a hard failure for non-Buzz remotes.This intentionally does not implement the broader transport fallback proposed in #2316; it makes the currently supported path fail clearly and safely.
Validation
just cicargo test -p git-credential-nostr(9 passed)Risk
Narrow: the new failure only applies when Buzz explicitly marks Nostr authentication as required and Git does not advertise
authtype.