Report broken CLI auth probes separately#2341
Open
wjbright wants to merge 1 commit into
Open
Conversation
Signed-off-by: Bright Williams <31846414+wjbright@users.noreply.github.com>
wjbright
force-pushed
the
agent/report-broken-cli-probes
branch
from
July 22, 2026 08:56
2377883 to
0ddf1b8
Compare
wjbright
marked this pull request as ready for review
July 22, 2026 08:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Buzz previously classified nearly every nonzero login-status probe as logged out. A broken Codex npm shim can fail with an error such as
Error: spawn /opt/codex/vendor/bin/codex ENOENT; onboarding then offers Sign in or Check again even though authentication cannot repair the installation.This introduces a
probe_failedstate across discovery, readiness, setup payloads, and the desktop UI. Unexpected CLI failures now retain a bounded diagnostic, while recognized logged-out signals still follow the existing authentication flow.Validation
cargo test --manifest-path desktop/src-tauri/Cargo.toml managed_agents::readiness::cli_probe::testsCARGO_TARGET_DIR=desktop/src-tauri/target cargo test -p buzz-acp nudge_body_cli_probe_failed_routes_to_agent_runtimespnpm --dir desktop test(3,373 passed)pnpm --dir desktop typecheckpnpm --dir desktop checkpnpm --dir desktop build:e2epnpm --dir desktop exec playwright test tests/e2e/onboarding-agent-defaults.spec.ts --project=smoke(16 passed)just fmt-checkjust desktop-tauri-fmt-check