Fix shared agent mentions#2333
Conversation
Co-authored-by: benclink <111811630+benclink@users.noreply.github.com> Signed-off-by: benclink <111811630+benclink@users.noreply.github.com>
|
Reviewed against The This also preserves the case the alternative #2314 regresses (deleting the pre-filter outright surfaces allowlisted non-member relay agents — details in #2349). And it's the only one of the two with unit + e2e regression coverage. I also confirmed a live external-Hermes repro that this fixes (in #2349). Looks ready on the merits — could this come out of draft so it can get a maintainer review and merge? Thanks for the clean test coverage. |
What changed
Root cause
The composer discarded every agent identity outside the current user's managed-agent list before evaluating channel membership and the relay response policy. Shared users therefore saw plain
@Agent Nametext instead of a resolved mention with the agent pubkey tag.User impact
Channel members can discover and mention shared agents that are bot members of the channel. Owner-only and allowlist response policies remain enforced by the existing downstream policy gate.
Validation
just ci