Skip to content

fix(desktop): align data deletion labels #2230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
baxen wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −4
Open

fix(desktop): align data deletion labels #2230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions desktop/src/features/settings/ui/ProfileSettingsCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,7 +979,7 @@ export function ProfileSettingsCard({
{isSignOutPending ? (
<Spinner aria-label="Signing out" className="h-4 w-4 border-2" />
) : null}
{isSignOutPending ? "Signing out…" : "Sign Out"}
{isSignOutPending ? "Signing out…" : "Delete my data"}
</Button>
</div>
<AlertDialog
Expand Down Expand Up @@ -1018,7 +1018,7 @@ export function ProfileSettingsCard({
});
}}
>
{isSignOutPending ? "Signing out…" : "Delete My Data"}
{isSignOutPending ? "Signing out…" : "Delete my data"}
</AlertDialogAction>
</AlertDialogFooter>
</AlertDialogContent>
Expand Down
7 changes: 5 additions & 2 deletions desktop/tests/e2e/signout-screenshots.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ test.describe("signout screenshots", () => {
});
});

test("signout-section — Sign Out card in Settings › Profile", async ({
test("signout-section — data deletion card in Settings › Profile", async ({
page,
}) => {
await installMockBridge(page);
Expand All @@ -32,6 +32,9 @@ test.describe("signout screenshots", () => {

const section = page.getByTestId("settings-signout");
await section.scrollIntoViewIfNeeded();
await expect(
section.getByRole("button", { name: "Delete my data" }),
).toBeVisible();

// Settle animations before capture.
await page.evaluate(() =>
Expand Down Expand Up @@ -59,7 +62,7 @@ test.describe("signout screenshots", () => {
await expect(dialog).toBeVisible({ timeout: 5_000 });
await expect(dialog.getByText("Sign out and wipe all data?")).toBeVisible();
await expect(
dialog.getByRole("button", { name: "Delete My Data" }),
dialog.getByRole("button", { name: "Delete my data" }),
).toBeVisible();

// Settle animations before capture.
Expand Down
Loading