fix(huddle): unify lifecycle reconstruction#2128
Open
Areson wants to merge 6 commits into
Open
Conversation
Share huddle lifecycle semantics between the channel card and header indicator so stale or drained huddles cannot retain a phantom participant. Co-authored-by: Ian Oberst <ioberst@squareup.com> Signed-off-by: Ian Oberst <ioberst@squareup.com> Co-authored-by: Codex <noreply@openai.com> Ai-assisted: true
Treat empty participant state as conclusive only when START remains in the subscription window. Keep long-running and locally current huddles active when newer lifecycle evidence supersedes the start-age fallback. Co-authored-by: Ian Oberst <ioberst@squareup.com> Signed-off-by: Ian Oberst <ioberst@squareup.com> Co-authored-by: Codex <noreply@openai.com> Ai-assisted: true
Fold relay participant transitions independently from client START timestamps, preserve uncertainty for truncated history, and stop the header from falling back to older sessions after a newer huddle ends. Co-authored-by: Ian Oberst <ioberst@squareup.com> Signed-off-by: Ian Oberst <ioberst@squareup.com> Co-authored-by: Codex <noreply@openai.com> Ai-assisted: true
Co-authored-by: Ian Oberst <ioberst@squareup.com> Signed-off-by: Ian Oberst <ioberst@squareup.com> Co-authored-by: Codex <noreply@openai.com> Ai-assisted: true
Co-authored-by: Ian Oberst <ioberst@squareup.com> Co-authored-by: Codex <noreply@openai.com> Ai-assisted: true Signed-off-by: Ian Oberst <ioberst@squareup.com>
Co-authored-by: Ian Oberst <ioberst@squareup.com> Co-authored-by: Codex <noreply@openai.com> Ai-assisted: true Signed-off-by: Ian Oberst <ioberst@squareup.com>
Areson
marked this pull request as ready for review
July 19, 2026 23:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The channel header could keep showing a phantom active huddle after everyone left, while the timeline card correctly showed the same huddle as ended.
What
Risk Assessment
Low to medium — scoped to desktop huddle lifecycle reconstruction and display state. Explicit END remains authoritative; inferred drain now requires a complete replay, while clock-skewed participant activity remains live.
References
just ciJoin active huddle (1 participant); final LEFT restoredStart huddlewith no phantom countGenerated with Codex